From bfa5a095f05d49c03c6f320e28866a6d9d602f6f Mon Sep 17 00:00:00 2001 From: Izumi Kawashima <schedul.xor@gmail.com> Date: Mon, 21 Nov 2016 01:50:14 +0900 Subject: [PATCH] UrlTileSource: use StringBuilder instead of String concatenation (#241) --- vtm/src/org/oscim/tiling/source/UrlTileSource.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vtm/src/org/oscim/tiling/source/UrlTileSource.java b/vtm/src/org/oscim/tiling/source/UrlTileSource.java index 9484afaa..3ef41493 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileSource.java @@ -1,6 +1,7 @@ /* * Copyright 2013 Hannes Janetzek * Copyright 2016 devemux86 + * Copyright 2016 Izumi Kawashima * * This file is part of the OpenScienceMap project (http://www.opensciencemap.org). * @@ -134,11 +135,12 @@ public abstract class UrlTileSource extends TileSource { } public String getTileUrl(Tile tile) { - String tileUrl = mUrl + mTileUrlFormatter.formatTilePath(this, tile); + StringBuilder sb = new StringBuilder(); + sb.append(mUrl).append(mTileUrlFormatter.formatTilePath(this, tile)); if (mApiKey != null) { - tileUrl += String.format("?api_key=%s", mApiKey); + sb.append("?api_key=").append(mApiKey); } - return tileUrl; + return sb.toString(); } public void setHttpEngine(HttpEngine.Factory httpFactory) {